Opened 7 months ago

Closed 4 months ago

#26189 closed task (fixed)

Remove our content policy hack for #8725

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-torbutton, TorBrowserTeam201808R
Cc: vanowm Actual Points:
Parent ID: #26544 Points:
Reviewer: Sponsor:

Description

Back then Yawning implemented a hack to defend leaking installed Tor Browser resources to content (see: #8725). Thus got upstreamed during the ESR60 timeframe (https://bugzilla.mozilla.org/show_bug.cgi?id=863246) and is available in Tor Browser now. We can think about removing this workaround from Torbutton then.

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by gk

Marked #22525 as duplicate as the fix in this ticket is essentially one for that problem as well.

comment:2 Changed 6 months ago by gk

Cc: vanowm added
Keywords: TorBrowserTeam201806 added
Priority: MediumHigh

Resolved #24948 as duplicate.

comment:3 Changed 6 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

Moving first batch of tickets to July 2018

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:5 Changed 4 months ago by gk

Parent ID: #26544

comment:6 Changed 4 months ago by arthuredelstein

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: newneeds_review

Here's my patch for review:

https://github.com/arthuredelstein/torbutton/commit/26189

I tested this patch with:

and confirmed that no information is leaking, as far as these patches can tell.

I also confirmed that https://trac.torproject.org/projects/tor/ticket/26544 is fixed with this patch.

comment:7 Changed 4 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201808R removed
Status: needs_reviewneeds_revision

Thanks, just one nit:

I think

pref("extensions.torbutton.resource_and_chrome_uri_fingerprinting",false);

should go now as well (still available in preferences.jsin your patch).

comment:8 Changed 4 months ago by arthuredelstein

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: needs_revisionneeds_review

Thanks for the review. Here's a revised patch:

https://github.com/arthuredelstein/torbutton/commit/26189+1

comment:9 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to master (commit b9b87bcb3105e7aafb42f162b4bb1e8fc7dc54ba).

Note: See TracTickets for help on using tickets.