Opened 8 months ago

Closed 8 months ago

#31920 closed defect (fixed)

Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

Reported by: Dbryrtfbcbhgf Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0, TorBrowserTeam201910R
Cc: tbb-team Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description (last modified by pospeselr)

If I resize TorBrowser 9.0a7 to its smallest size and back to its original size, this causes the shield button to do nothing when clicked on. I made a video showing the bug occur.https://trac.torproject.org/projects/tor/ticket/31920#no4

Child Tickets

Change History (11)

comment:1 Changed 8 months ago by Dbryrtfbcbhgf

Video showing the bug occur. https://streamable.com/tw3pc

comment:2 Changed 8 months ago by Thorin

Its the width. I think I've seen before this in Firefox as well. If the button/icon moves into the overflow menu (its around the 400px mark), when you bring it back its popup action is broken - maybe Dão Gottwald at Mozilla has heard of this. I just tested FF Nightly with a uMatrix button and that worked just fine.

PS: As soon as you open a new window, it fixes it for all windows.

Edit: upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1538653

Last edited 8 months ago by Thorin (previous) (diff)

comment:3 Changed 8 months ago by gk

Keywords: tbb-9.0 added

Dbryrtfbcbhgf: Does the current stable work for you or are you seeing the same issue with it? On my Linux box at least it seems it's only an alpha issue. It's not related to letterboxing being on/off either.

One could test whether #31251 plays a role here as it never landed in stable.

comment:4 Changed 8 months ago by gk

Status: newneeds_information

comment:5 Changed 8 months ago by Dbryrtfbcbhgf

gk, The current stable works correctly.

comment:6 Changed 8 months ago by pospeselr

Description: modified (diff)
Owner: changed from tbb-team to pospeselr
Status: needs_informationassigned

So this is probably because I tried to be clever and cache the button element, rather than doing a querySelector each time it's needed.

comment:7 Changed 8 months ago by pospeselr

Cc: tbb-team added

comment:8 Changed 8 months ago by pospeselr

Keywords: TorBrowserTeam201910 added
Points: 0.25

comment:9 Changed 8 months ago by pospeselr

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

Removed the caching. Protip for future me and future yous, don't cache things you don't control the lifetime of.

tor-browser : https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31920_review

comment:10 Changed 8 months ago by pospeselr

Actual Points: 0.1
Points: 0.250.1

comment:11 Changed 8 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to tor-browser-68.1.0esr-9.0-3 (commit ec6ab177fd17a27ee6c7305c5433870d8d097097) (with typo fixups etc. to avoid another roundtrip).

Note: See TracTickets for help on using tickets.