option to stop telling me firefox is going to start
With vidalia 3.1-alpha, there is a new 'info message' or pop-up that occurs after tor bootstraps, but firefox hasn't started. there should be an option to disable/enable it.
Activity
Replying to sirop:
Does this mean we can load the tbb plugin without restarting the firefox?
O.k. To reproduce the bug: ./start-tor-browser wait until Firefox with the tbb plugin is loaded stop TOR in the Vidalia menu restart TOR in the Vidalia menu see the message "firefox will start soon" although Firefox is already running
My proposal: either have an option to disable this info message or have a different info message saying something like "Firefox is already running. If the Tor network is reestablished, feel free to surf".
Trac:
Username: sirop
Owner: chiiph to sirop
Status: needs_information to assignedThe whole point of this is to find a solution, so if you've got a possible one, please show us.
You should create a branch named something like bug5352_notification with this fix, so I can check it out and merge if it's ok. Mark the ticket as needs_review when you propose a patch/branch with a fix, and I'll either close it and merge or mark it as needs_revision with some comments on what you should change. When those changes are done, you mark it as needs_review again pointing to the place where the changes are, and so on.
-
I cannot upload anything either to github or gitorious, always get "fatal: The remote end hung up unexpectedly" error. Don't know why.
That's why git diff output at pastebin: http://pastebin.com/ChmFhCTP
for the time being.
Trac:
Username: sirop -
Replying to chiiph:
Ok. Hope, i did it the right way on the github:
https://github.com/sirop/vidalia-plugins/commit/c6174b4d5cf62505ab199a0c0ab33a4928392c9c
Trac:
Username: sirop
Status: assigned to needs_review Trac:
download.php_i_ChmFhCTPOverall looks good. A couple of notes:
- If I start TBB with DontShowTrayBox=false, then change it to true and I restart tor, I will still see the notification.
- You have changed the way the settings behave, which is another issue, not this one.
- It's Tor, not TOR.
- There are a couple of bad indentations (see the first if in that patch, for example).
Trac:
Status: needs_review to needs_revision-
Replying to chiiph:
Overall looks good. A couple of notes:
- If I start TBB with DontShowTrayBox=false, then change it to true and I restart tor, I will still see the notification.
I cannot reproduce this error. Maybe, you've forgotten to Save under Plugins --> Browser Bundle Settings.
- You have changed the way the settings behave, which is another issue, not this one. Yes, my fault. Had to do it as firefox did not start otherwise. Will try to make up a ticket for launchBrowserFromDirectory function these days.
- It's Tor, not TOR. Will be corrected.
- There are a couple of bad indentations (see the first if in that patch, for example). Yes, I looked it up in https://gitweb.torproject.org/vidalia.git/blob/HEAD:/HACKING Will be changed.
Trac:
Username: sirop Replying to sirop:
Replying to chiiph:
Overall looks good. A couple of notes:
- If I start TBB with DontShowTrayBox=false, then change it to true and I restart tor, I will still see the notification.
I cannot reproduce this error. Maybe, you've forgotten to Save under Plugins --> Browser Bundle Settings.
With "restart tor" I meant: click the "Stop tor" button, and then click the "Start tor" one.
Another way of putting this is: you don't check what the option is set to inside showWaitDialog().
-
Replying to chiiph: Bundle Settings.
With "restart tor" I meant: click the "Stop tor" button, and then click the "Start tor" one.
Another way of putting this is: you don't check what the option is set to inside showWaitDialog().
I changed showWaitDialog() as you propose. https://github.com/sirop/vidalia-plugins/commit/a265d669704d3052da4ff36bac4e5ec63ea7e7ae
launchBrowserFromDirectory() was also changed, although "it is a different issue". I think, I formulated https://trac.torproject.org/projects/tor/ticket/5364 not clear enough, but I'll try to correct this until 5 p.m. German time to-day.
Trac:
Username: sirop
Status: needs_revision to needs_review -
https://github.com/sirop/vidalia-plugins/commits/bug5352_notifications
Based on the last master. Hope, my indentation is no longer bad ;).
Trac:
Username: sirop
Status: needs_revision to needs_review Three things:
- Yes, bad indentation is still there. For the future, check the commit in github before posting it here, you'll see what I'm talking about (in case everything looks ok in your editor).
- Why did you commented out this if(QDir(browserDirectory).isRelative()) ?
- You should remove vdebugs like: vdebug(browserDirectory + " line 196, sirop");
Trac:
Status: needs_review to needs_revision-
Replying to chiiph:
Three things:
- Yes, bad indentation is still there. For the future, check the commit in github before posting it here, you'll see what I'm talking about (in case everything looks ok in your editor).
- Why did you commented out this if(QDir(browserDirectory).isRelative()) ?
- You should remove vdebugs like: vdebug(browserDirectory + " line 196, sirop"); One more try: https://github.com/sirop/vidalia-plugins/commit/bea98c70ab5a130e7d3cad308dd37094ee879294
Yes, my editor showed something different before. :)
Trac:
Username: sirop