Opened 5 years ago

Last modified 12 days ago

#9018 new defect

Concerning debug assertions in the font patch

Reported by: mikeperry Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-firefox-patch
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While trying to get to the bottom of the latest round of TBB crash bugs, gk noticed these assertions that were seemingly introduced in debug builds:

###!!! ASSERTION: bad font face url passed to fontloader: 'aFontFaceSrc && !aFontFaceSrc->mIsLocal', file /home/firefox64/TBB/CrashFontDebug/mozilla-esr17/layout/style/nsFontFaceLoader.cpp, line 809
###!!! ASSERTION: null font uri: 'aFontFaceSrc->mURI', file /home/firefox64/TBB/CrashFontDebug/mozilla-esr17/layout/style/nsFontFaceLoader.cpp, line 810

He wrote this in https://trac.torproject.org/projects/tor/ticket/8939#comment:1:

"This does neither happen with a vanilla Firefox (+ the Tor Browser .mozconfig) nor a patched Firefox without the patch 0011. Looking a bit deeper then 2a543b9359029938dfa98f8e285fb5528104d527 is still okay but b0e19e9a7e94dcbd6e50ea3739c5b3ce218fe57c is not anymore. Thus, this seems to be a bug in the fix for #8455 and probably responsible for all the crash bugs that showed up recently..."

We later discovered it was not responsible for the majority (or any?) of the crash bugs, but it certainly should be investigated.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by mikeperry

Those commits hashes are on maint-2.4 of torbrowser.git.

comment:2 Changed 3 years ago by gk

I got those assertions when requesting https://code.google.com/codejam/contest/registration using a TBB based on Firefox 24.4.0 ESR.

comment:3 Changed 3 years ago by erinn

Keywords: tbb-firefox-patch added

comment:4 Changed 3 years ago by erinn

Component: Firefox Patch IssuesTor Browser
Owner: changed from mikeperry to tbb-team

comment:5 Changed 12 days ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.